fix: update devcontainer's docker image to match github#1323
Closed
vegerot wants to merge 1 commit into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates the VS Code devcontainer configuration to build from a different Dockerfile (manylinux 2.34), likely to align the local dev environment with a new base image/toolchain.
Changes:
- Switched the devcontainer build Dockerfile from
sapling-cli-ubuntu-22.04.Dockerfiletomanylinux_2_34.Dockerfile.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -2,7 +2,7 @@ | |||
| "name": "Sapling", | |||
| "build": { | |||
| "context": "..", | |||
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this in D106554635. (Because this pull request was imported automatically, there will not be any future comments.) |
meta-codesync Bot
pushed a commit
that referenced
this pull request
May 28, 2026
Summary: Pull Request resolved: #1323 Reviewed By: quark-zju Differential Revision: D106554635 fbshipit-source-id: ad5413c8a1fe45624b6ec3270409e34ca1b4c802
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.